minecraft/brass-and-sigil
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pack: v0.34.1 — bnstoolkit hotfix 0.1.1 #70

Merged
Matt merged 1 commits from hotfix/bnstoolkit-0.1.1 into main 2026-06-07 00:18:38 +00:00
Conversation 0 Commits 1 Files Changed 2
+2 -2
Matt commented 2026-06-07 00:18:31 +00:00
Owner
Copy Link
Copy Source

Summary

  • 0.1.0 brought the server down during construct-mods: IllegalArgumentException: class uk.sijbers.bnstoolkit.BnsToolkit has no @SubscribeEvent methods, but register was called anyway.
  • 0.1.1 removes the bogus NeoForge.EVENT_BUS.register(this) call. Will come back in M1 alongside the first @SubscribeEvent listener.
  • Jar already staged in /srv/fast/brass-sigil-server/server/mods/. Server is currently down (JVM exited; wrapper supervisor is up; web admin on :8080 needs a Start click).

What I couldn't verify

Cannot bring the JVM back myself — the admin panel needs auth I'm not supposed to be guessing, and systemctl restart would also count as taking the live service down. So this is shipped "safe" — fix on disk, fix in git, but the user has to click Start in the panel to confirm the load succeeds on the next boot.

Lessons

  • gradle build doesn't simulate construct-mods. Will add a gameTestServer Gradle run to catch this class of bug pre-deploy in M1.

🤖 Generated with Claude Code

## Summary - 0.1.0 brought the server down during construct-mods: `IllegalArgumentException: class uk.sijbers.bnstoolkit.BnsToolkit has no @SubscribeEvent methods, but register was called anyway.` - 0.1.1 removes the bogus `NeoForge.EVENT_BUS.register(this)` call. Will come back in M1 alongside the first @SubscribeEvent listener. - Jar already staged in `/srv/fast/brass-sigil-server/server/mods/`. Server is currently down (JVM exited; wrapper supervisor is up; web admin on :8080 needs a Start click). ## What I couldn't verify Cannot bring the JVM back myself — the admin panel needs auth I'm not supposed to be guessing, and `systemctl restart` would also count as taking the live service down. So this is shipped "safe" — fix on disk, fix in git, but the user has to click Start in the panel to confirm the load succeeds on the next boot. ## Lessons - gradle build doesn't simulate construct-mods. Will add a `gameTestServer` Gradle run to catch this class of bug pre-deploy in M1. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Matt added 1 commit 2026-06-07 00:18:31 +00:00
pack: v0.34.1 — bnstoolkit hotfix 0.1.1 (fixes mod-load crash) ecd5933f9f 
0.1.0 brought the dedicated server down during construct-mods because
the @Mod constructor called NeoForge.EVENT_BUS.register(this) without
any @SubscribeEvent methods on the class — which NeoForge 21.1 treats
as a fatal IllegalArgumentException.

Caught only after live-deploy (gradle build doesn't simulate the
construct-mods step). 0.1.1 removes the bogus register call. The
@SubscribeEvent listeners will come back in M1 alongside the first
real event handler.

Server has been brought down by the crash and is waiting for a manual
start via the web admin panel. The fixed jar is staged in
/srv/fast/brass-sigil-server/server/mods/ already.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Matt merged commit 338617e855 into main 2026-06-07 00:18:38 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Matt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: minecraft/brass-and-sigil#70
Delete Branch "hotfix/bnstoolkit-0.1.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?